refactor remove multiple reflect metadata

[jbpionnier]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[coveralls]

Coverage decreased (-0.5%) to 93.157% when pulling 457c57b on jbpionnier:refactor_remove_reflect_metadata into 098afe6 on nestjs:master.

[coveralls]

Pull Request Test Coverage Report for Build 1141

• 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.04%) to 93.656%

---

Totals
Change from base Build 1136:	-0.04%
Covered Lines:	2658
Relevant Lines:	2780

---

💛 - Coveralls

[marcus-sa]

reflect-metadata should be obsolete and only imported a single time by the user themselves in their entry file.
Every time the package gets imported, it'll override the global Reflect scope and remove all metadata, so if two packages depends on it and one of them imports it themselves, the other package won't be able to resolve the metadata they added.

[jbpionnier]

ok... this is already better for Nest ?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.