Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): root path middleware not applied when setting the global prefix #12179

Closed

Conversation

CodyTseng
Copy link
Contributor

@CodyTseng CodyTseng commented Aug 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #11572

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Aug 1, 2023

Pull Request Test Coverage Report for Build 8835fc59-fe00-45a0-886e-1cbcd9a0dccb

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.161%

Totals Coverage Status
Change from base Build 2bf2e4c8-5da9-4dd1-8f93-3b733029afc6: 0.001%
Covered Lines: 6737
Relevant Lines: 7310

💛 - Coveralls

@CodyTseng CodyTseng marked this pull request as ready for review August 1, 2023 14:26
@CodyTseng CodyTseng changed the title fix: the root path middleware not applied when setting the global prefix fix(core): root path middleware not applied when setting the global prefix Aug 3, 2023
@CodyTseng CodyTseng marked this pull request as draft August 24, 2023 15:18
@CodyTseng CodyTseng marked this pull request as ready for review August 25, 2023 14:25
@kamilmysliwiec
Copy link
Member

I created a new PR based off this one with a slightly different approach in order to avoid introducing breaking changes Let's track this here #13337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants