-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: refactor(common): Add type safety to loadPackage #12236
base: master
Are you sure you want to change the base?
Conversation
46de806
to
675da2d
Compare
This will lead to compilation errors for projects with |
@kamilmysliwiec Oh, I see. How about adding // @ts-ignore:next-line
import type * as Ws from 'wsss';
// @ts-ignore:next-line
import type * as Mqtt from 'mqtt';
// @ts-ignore:next-line
import type * as Nats from 'nats';
// @ts-ignore:next-line
import type * as GrpcJs from '@grpc/grpc-js';
// other imports... |
When consumers disabled 'skipLibCheck' they were getting compilation error cause optional dependencies wouln't be installed. Fix that with a hacky trick.
Pull Request Test Coverage Report for Build 20d1cbae-50c8-474b-b0d4-0a9103e7c1c8
💛 - Coveralls |
I agree the whole mr is like a hack but apparently generic import type is not Update: |
PR Checklist
Please check if your PR fulfills the following requirements:
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
DESCRIPTION:
There are 2 problems in
fastify-adapter.ts
file on lines438
and453
. Can anybody else fix that :) I didn't want to simply addas any
to it...