feat(core): instantiate non-static custom classes #12344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to construct request-scoped custom classes by passing a `contextId` to `moduleRef.create`
|
LGTM |
rickdgeerling
deleted the
feat/instantiate-non-static-custom-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Custom classes can only be static, because they are not associated with a contextId, and thus cannot find an associated request.
What is the new behavior?
Allows us to construct request-scoped custom classes by passing a
contextIdtomoduleRef.createDoes this PR introduce a breaking change?
Other information
This feature is really small and the moduleRef is not directly covered. Shall I add tests and/or docs?