Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add communication groups for Chinese developers #1287

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

dzzzzzy
Copy link
Contributor

@dzzzzzy dzzzzzy commented Nov 14, 2018

Chinese developers are growing, and in order to allow Chinese developers to communicate and share with each other, I have established a communication group.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: add communication groups for Chinese developers in readme_zh

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Chinese developers are growing, and in order to allow Chinese developers to communicate and share with each other, I have established a communication group.
@coveralls
Copy link

coveralls commented Nov 14, 2018

Pull Request Test Coverage Report for Build 1226

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.736%

Totals Coverage Status
Change from base Build 1218: 0.0%
Covered Lines: 2823
Relevant Lines: 2947

💛 - Coveralls

@BrunnerLivio
Copy link
Member

What kind of communication service is this? Is for example Discord or Slack still not available in China? I think it would be easier to have the same communication solution if we're going to switch from Gitter (related #891) but I totally understand if the named services are not going to be unblocked we may do not have any other solution..

@dzzzzzy
Copy link
Contributor Author

dzzzzzy commented Nov 14, 2018

This communication service is tencent QQ group,I add it to readme_zh because many Chinese developers are using the tencent QQ group for the communication of technology in China.

Discord, Slack and gitter are very good, but they are some times not available in China, so I think the tencent QQ group is a better communication solution for Chinese developers.

@BrunnerLivio
Copy link
Member

@dzzzzzy I see.. Coincidentally I am currently at the Openstack Summit in Berlin and I talked to the Tencent Cloud guys. Seems like it is similar to WhatsApp or Telegram. In my opinion this is fine, but the readme should state that this channel is not officially supported and maintained by the NestJS org members. What do you think @kamilmysliwiec

@dzzzzzy
Copy link
Contributor Author

dzzzzzy commented Nov 15, 2018

@BrunnerLivio If kamil agree this, I can add more state about that this channel is not officially supported and maintained by the NestJS org members, otherwise you can close this PR.

Thank you for your reply.

@kamilmysliwiec
Copy link
Member

@BrunnerLivio If kamil agree this, I can add more state about that this channel is not officially supported and maintained by the NestJS org members, otherwise you can close this PR.

That would be fine for now. @dzzzzzy feel free to do that

Add more state about Chinese developer communication channel.
@dzzzzzy
Copy link
Contributor Author

dzzzzzy commented Nov 21, 2018

@kamilmysliwiec I have updated this commit, I think it can be merged into master branch.

@kamilmysliwiec
Copy link
Member

Thanks @dzzzzzy!

@kamilmysliwiec kamilmysliwiec merged commit dd882ac into nestjs:master Nov 29, 2018
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants