Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(microservices): modify rmq options interface #12915

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

NivSv
Copy link

@NivSv NivSv commented Dec 12, 2023

remove the comments from the types of the rmq options interface to get types and modify the types
previous behavior: queueOptions and socketOptions fields type is any

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • [ v ] Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

any type for socketOptions and queueOptions fields in RMQ microservice options

Issue Number: N/A

What is the new behavior?

get autocomplete for socketOptions and queueOptions fields in RMQ microservice options because of the types

Does this PR introduce a breaking change?

  • Yes
  • [ x ] No

Other information

remove the comments from the types of the rmq options interface to get
types and modify the types
previous behavior: queueOptions and socketOptions fields type is any
@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 52c0170f-cb19-427f-ac8f-eb5fced3d7b2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.258%

Totals Coverage Status
Change from base Build a2138bee-e39e-445f-b2ab-320ae7840dc5: 0.0%
Covered Lines: 6697
Relevant Lines: 7259

💛 - Coveralls

change the interface 'ClientProperties' name to pascal case
@kamilmysliwiec kamilmysliwiec merged commit 0885d4f into nestjs:master Dec 18, 2023
3 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

@NivSv NivSv deleted the add-rmq-options-types branch December 18, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants