refactor(changelog): update simplified imports #13016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(common): fair amount of packages were missing file imports/exports
Pull Request Test Coverage Report for Build 77ceff41-a6ad-4880-a176-83682d6633aa
💛 - Coveralls |
dammy001
reviewed
Jan 7, 2024
| @@ -2,3 +2,4 @@ export * from './request-method.enum'; | |||
| export * from './http-status.enum'; | |||
| export * from './shutdown-signal.enum'; | |||
| export * from './version-type.enum'; | |||
| export * from './http-status.enum'; | |||
There was a problem hiding this comment.
This has been added on line 2.
| @@ -1 +1,2 @@ | |||
| export * from './streamable-file'; | |||
| export * from './interfaces'; | |||
There was a problem hiding this comment.
Do we need to export all interfaces? Some might be internal.
There was a problem hiding this comment.
as of now, the ./interfaces/index.ts has only public interfaces.
| @@ -1 +1,13 @@ | |||
| export * from './forward-ref.util'; | |||
| export * from './assign-custom-metadata.util'; | |||
There was a problem hiding this comment.
Some util functions are not meant to be exported.. They're marked as internal.
There was a problem hiding this comment.
yeah
AFIAK those functions at utils are for internal usage of @nestjs/common. They must not be public like this.
|
Most of these missing imports are intentional (not a public API) |
rickdgeerling
added a commit
to rickdgeerling/nest
that referenced
this pull request
Sep 20, 2024
Fastify expects uppercase and won't auto-add the HEAD method otherwise Closes nestjs#13016
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(common): fair amount of packages were missing file imports/exports
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Simplified exporting for missing files
Does this PR introduce a breaking change?
Other information
I also saw a bunch of other directories that are missing correct exporting, please let me know if that change will help you, so I will know I can continue with other directories 😉