refactor: general refactor (explicit types, generics, components)

[kamilmysliwiec]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[coveralls]

Pull Request Test Coverage Report for Build 1232

• 169 of 176 (96.02%) changed or added relevant lines in 42 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 93.712%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/microservices/server/server-grpc.ts	4	5	80.0%
packages/core/scanner.ts	20	22	90.91%
packages/core/injector/module.ts	45	49	91.84%

Files with Coverage Reduction	New Missed Lines	%
packages/core/injector/module.ts	1	86.67%

Totals
Change from base Build 1218:	-0.02%
Covered Lines:	2838
Relevant Lines:	2964

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 1237

• 276 of 286 (96.5%) changed or added relevant lines in 71 files are covered.
• 3 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.03%) to 93.701%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/microservices/server/server-grpc.ts	4	5	80.0%
packages/microservices/server/server-redis.ts	5	6	83.33%
packages/websockets/web-sockets-controller.ts	1	2	50.0%
packages/core/scanner.ts	28	31	90.32%
packages/core/injector/module.ts	45	49	91.84%

Files with Coverage Reduction	New Missed Lines	%
packages/common/decorators/http/route-params.decorator.ts	1	87.8%
packages/core/injector/module.ts	1	86.67%
packages/core/router/routes-resolver.ts	1	88.46%

Totals
Change from base Build 1218:	-0.03%
Covered Lines:	2846
Relevant Lines:	2973

---

💛 - Coveralls

[BrunnerLivio]

Really great step forward!
That is what I call one productive "break"

---

What about https://github.com/nestjs/nest/pull/1307/files#diff-bda512087c3a50709e8088dbaecfe8c6L39
showDeprecatedWarnings overrideModuleMetadata? Shouldn't these also be removed?

[BrunnerLivio]

Should this still exist? Shouldn't we just let it fail in case someone actually uses components?

[kamilmysliwiec]

I think that all changes that have been made so far, don't have to be considered as "breaking changes" which means that we wouldn't have to bump major version. That thing on the other hand (overrideComponent) should be probably removed in another PR :D

[BrunnerLivio]

Oh I see.. Then I am fine with this PR :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.