Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): when having multiple versions on middleware routes builder #13193

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #13093

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

@micalevisk micalevisk changed the title fix(core): when having multiple versions on middleware builder fix(core): when having multiple versions on middleware route builder Feb 9, 2024
@micalevisk micalevisk changed the title fix(core): when having multiple versions on middleware route builder fix(core): when having multiple versions on middleware routes builder Feb 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build bafc0113-b8cc-4fce-b433-ecb4a31fbd5c

  • -3 of 27 (88.89%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 92.172%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/middleware/route-info-path-extractor.ts 19 22 86.36%
Totals Coverage Status
Change from base Build 97ad4a6d-b0b5-42af-9166-b023f826fa18: -0.03%
Covered Lines: 6735
Relevant Lines: 7307

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Great PR ❤️

Thank you

@micalevisk micalevisk deleted the fix/issue-13093 branch February 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware doesn't get called if more than one version is specified in version
3 participants