Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update broken link in SetMetadata decorator documentation #13346

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

tomaszwysocki
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:
    Documentation

What is the current behavior?

The current behavior is that the link in the SetMetadata decorator documentation is broken and redirects to the wrong page.

What is the new behavior?

The new behavior is that the broken link in the SetMetadata decorator documentation has been fixed to accurately direct users to the Reflection section within the Execution Context page of the NestJS fundamentals documentation.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0a9caa66-0c45-437d-9820-806735b64eb9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.146%

Totals Coverage Status
Change from base Build fad5078e-9529-46ad-977e-491c6acb241f: 0.0%
Covered Lines: 6734
Relevant Lines: 7308

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit df37ea1 into nestjs:master Mar 21, 2024
3 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

@tomaszwysocki tomaszwysocki deleted the fix-broken-link branch March 21, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants