Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сorrection of Reflector types #13388

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Сorrection of Reflector types #13388

wants to merge 2 commits into from

Conversation

AlexRMU
Copy link

@AlexRMU AlexRMU commented Apr 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

closes #13383

@coveralls
Copy link

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 142de026-e7b7-41a2-bb12-e6facc2f16bd

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.123%

Totals Coverage Status
Change from base Build eacd3e56-4bed-4f5e-9bab-412a10335aab: 0.0%
Covered Lines: 6736
Relevant Lines: 7312

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec mentioned this pull request Apr 3, 2024
15 tasks
@kamilmysliwiec
Copy link
Member

Could we add unit tests for this change?

@AlexRMU
Copy link
Author

AlexRMU commented Apr 3, 2024

I see that more tests need to be added for getAll and getAllAndOverride, as well as more type checks for all.
It is better for the members to do this or create a separate issue.

Copy link

@benjGam benjGam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this won't involve any breaking change ?

@AlexRMU
Copy link
Author

AlexRMU commented Apr 3, 2024

For those who used a decorator with transformation, the return type was unknown, and now it will become TTransformed.
Nothing will change for the others.

@benjGam
Copy link

benjGam commented Apr 5, 2024

For those who used a decorator with transformation, the return type was unknown, and now it will become TTransformed. Nothing will change for the others.

Okay, thanks for your reply :)

@micalevisk
Copy link
Member

@AlexRMU can you please share a code snippet?

@AlexRMU
Copy link
Author

AlexRMU commented Apr 16, 2024

Snippet with what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type (as in #12264)
5 participants