Multer error fieldname #13407
Open
Multer error fieldname #13407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multer errors may include a 'field' property for certain errors. Pass it along into the error message.
Add the possible `field` property to the `error` arg in `transformExecption`.
Pull Request Test Coverage Report for Build aa3c3f7d-478d-43ae-b28d-1cef4587eccdDetails
💛 - Coveralls |
benjGam
approved these changes
Apr 26, 2024
|
What would be a better way to classify it? |
I would personally classify it as a "Bugfix" or "Feature" determining it on the base of the first idea with which this system was developed But here, i'm not able to tell if you fixed a bug or implement a new feature, so i can't tell. But i have the feeling that do not match "Refactor" criteria. |
|
Yes, I think I would categorize it as a fix. Multer provides the fieldname of the file if an error occurs, but this package does not pass it along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When transforming a
MulterErrorinto a Nest error, the optionalfieldproperty is dropped.Issue Number: N/A
What is the new behavior?
The
fieldproperty is included in the error message, if applicable.Does this PR introduce a breaking change?
Other information
If Multer throws an error, some identifying information is hidden from the error message.
https://github.com/expressjs/multer/blob/aa42bea6ac7d0cb8fcb279b15a7278cda805dc63/lib/multer-error.js#L19. This is where Multer adds the optional
fieldproperty.