Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(class-transformer): plainToClass is deprectated and replaced with plainToInstance #13628

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

tomflorentin
Copy link

@tomflorentin tomflorentin commented May 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Class transformer depreacted plainToClass and now recommend using plainToInstance. They are the same, just renamed.
NestJS uses this deprecated method.
Changing it will avoid future problems if class transformer delete it.

Issue Number: N/A

What is the new behavior?

The behaivoir of the code is the same, but

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0e331174-8582-49e9-86b2-db20f61b1e40

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.124%

Totals Coverage Status
Change from base Build 94cfa8c0-2cff-488c-b4b7-6f54fde1b9de: 0.0%
Covered Lines: 6737
Relevant Lines: 7313

💛 - Coveralls

@tomflorentin tomflorentin marked this pull request as ready for review May 29, 2024 12:52
@tomflorentin
Copy link
Author

up

@betsara-vev
Copy link

amazing !

@kamilmysliwiec kamilmysliwiec added this to the 11.0.0 milestone Nov 6, 2024
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 11.0.0 November 6, 2024 11:50
@kamilmysliwiec kamilmysliwiec merged commit 6ea78d5 into nestjs:11.0.0 Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants