Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): grpc package name can be specified with service name #13731

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

JadenKim-dev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #13719

If there are gRPC services with duplicate names, it is not possible to register handlers separately even if they are distinguished by different packages.

What is the new behavior?

In decorators like @GrpcMethod, specifying the service name like package.MethodName allows handlers to be registered for each package separately.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 793707e2-04d1-4ccc-919f-9801d0933acd

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 92.21%

Totals Coverage Status
Change from base Build 0f9b0016-1853-4775-8f4d-a4d89fc35f0f: 0.003%
Covered Lines: 6747
Relevant Lines: 7317

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 2785b6f3-f183-43bc-8a6c-a51dceb9710a

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 92.21%

Totals Coverage Status
Change from base Build 0f9b0016-1853-4775-8f4d-a4d89fc35f0f: 0.003%
Covered Lines: 6747
Relevant Lines: 7317

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec kamilmysliwiec merged commit ccfa23e into nestjs:master Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants