Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(@nestjs/core): Check lifecycle hook order #1659

Merged
merged 1 commit into from
Mar 16, 2019

Conversation

BrunnerLivio
Copy link
Member

@BrunnerLivio BrunnerLivio commented Mar 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

The order of the lifecycle events is not backed by any test

What is the new behavior?

Added e2e test which checks which hook gets called in which order.

OnModuleInit -> OnApplicationBootstrap -> OnModuleClose -> OnApplicationShutdown.

If this is not the expected behavior, we would have to change the order.

Related pr: docs.nestjs.com#267

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Mar 16, 2019

Pull Request Test Coverage Report for Build 1652

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.683%

Totals Coverage Status
Change from base Build 1647: 0.0%
Covered Lines: 2992
Relevant Lines: 3137

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Nice. Thanks @BrunnerLivio 💪

@kamilmysliwiec kamilmysliwiec merged commit 8e2f64d into nestjs:master Mar 16, 2019
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants