Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor() remove optional package #3041

Merged
merged 1 commit into from Sep 30, 2019
Merged

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2826

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.349%

Totals Coverage Status
Change from base Build 2792: 0.0%
Covered Lines: 4141
Relevant Lines: 4343

💛 - Coveralls

optional('@nestjs/microservices/microservices-module') || ({} as any);
const { SocketModule } = optionalRequire(
'@nestjs/websockets/socket-module',
() => require('@nestjs/websockets/socket-module'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to send the loaderFn param?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required for the sake of bundlers compatibility (e.g. webpack)

@kamilmysliwiec kamilmysliwiec added this to the 6.8.0 milestone Sep 30, 2019
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.8.0 September 30, 2019 08:14
@kamilmysliwiec kamilmysliwiec merged commit 957bd39 into 6.8.0 Sep 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/remove-optional branch September 30, 2019 08:22
@kamilmysliwiec kamilmysliwiec mentioned this pull request Sep 30, 2019
3 tasks
@lock
Copy link

lock bot commented Dec 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants