-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): class-validator interface v0.10.1 #3059
fix(common): class-validator interface v0.10.1 #3059
Conversation
Pull Request Test Coverage Report for Build 3076
💛 - Coveralls |
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammatical errors... 😄
@@ -42,7 +52,7 @@ export interface ValidatorOptions { | |||
value?: boolean; | |||
}; | |||
/** | |||
* Setting true will cause failed validation of unknown objects. | |||
* Settings true will cause fail validation of unknown objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kamilmysliwiec Not sure why this was changed. The grammar doesn't sound correct 😅
@@ -25,7 +35,7 @@ export interface ValidatorOptions { | |||
groups?: string[]; | |||
/** | |||
* If set to true, the validation will not use default messages. | |||
* Error message will always be undefined if it's not explicitly set. | |||
* Error message always will be undefined if its not explicitly set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error messages will always be undefined if they are not explicitly set
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information