fix(common): class-validator interface v0.10.1 #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruscon
changed the title
Pull Request Test Coverage Report for Build 3076
💛 - Coveralls |
|
Thank you! |
3 tasks
| @@ -42,7 +52,7 @@ export interface ValidatorOptions { | |||
| value?: boolean; | |||
| }; | |||
| /** | |||
| * Setting true will cause failed validation of unknown objects. | |||
| * Settings true will cause fail validation of unknown objects. | |||
There was a problem hiding this comment.
@kamilmysliwiec Not sure why this was changed. The grammar doesn't sound correct 😅
| @@ -25,7 +35,7 @@ export interface ValidatorOptions { | |||
| groups?: string[]; | |||
| /** | |||
| * If set to true, the validation will not use default messages. | |||
| * Error message will always be undefined if it's not explicitly set. | |||
| * Error message always will be undefined if its not explicitly set. | |||
There was a problem hiding this comment.
Error messages will always be undefined if they are not explicitly set
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information