feat(): add ip route param

[iniel]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Added ip param decorator for HTTP route handlers.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

[coveralls]

Pull Request Test Coverage Report for Build 5377

• 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
• 11 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.001%) to 95.292%

---

Files with Coverage Reduction	New Missed Lines	%
packages/core/injector/module.ts	11	86.67%

Totals
Change from base Build 5359:	-0.001%
Covered Lines:	4372
Relevant Lines:	4588

---

💛 - Coveralls

[BrunnerLivio]

Really nice PR, well done!!!

From my side this feature is good to go. Though @iniel for future contributions, please create an issue before creating a pull request. This workflow is commonly done, so you do not waste time implementing something, which does not fit the core teams vision :)

[kamilmysliwiec]

Even though I really like this PR, I'm slightly concerned that adding more and more decorators that simply pick properties from the request instance might be redundant :( Like, if one wants to get an IP address and use decorator for that, it can be achieved with one line of code:

export const Ip = createParamDecorator((data, req) => req.ip);

[iniel]

You are right in this concern. Basically I think most of the fields in request object are too low level to be used in handler business logic (like method, host etc.). And it's better to use them only in specialized services.
But ip is only field left appropriate to use in handler but have no decorator from the box. So my motivation was - not to hardcode lonely local decorator with createParamDecorator but push this to upstream :)

[kamilmysliwiec]

Thanks for your input @iniel. Sounds reasonable :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.