-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): use class references as keys (container) #6141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For class providers use a class reference instead of a class name as an injection token to address dependency injection conflicts when two classes share the same name. resolve #5591
…ooleks-fix/injector
3 tasks
Pull Request Test Coverage Report for Build 078b58e0-e3d1-42d2-bc07-d6e6557503d8
💛 - Coveralls |
3 tasks
This was referenced Jul 7, 2021
This was referenced Jul 10, 2021
This was referenced Jul 19, 2021
This was referenced Jul 26, 2021
This was referenced Aug 3, 2021
CarsonF
added a commit
to SeedCompany/cord-api-v3
that referenced
this pull request
Sep 19, 2021
This is a requirement from Nest 8 change where classes are registered by class instance instead of class name. nestjs/nest#6141 nestjs/nest#5591
CarsonF
added a commit
to SeedCompany/cord-api-v3
that referenced
this pull request
Sep 19, 2021
This is a requirement from Nest 8 change where classes are registered by class instance instead of class name. nestjs/nest#6141 nestjs/nest#5591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
The container uses class references as providers/controllers/injectables keys instead of their names.
Does this PR introduce a breaking change?
Other information