Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core) rephrase error messages #839

Merged
merged 1 commit into from
Jul 4, 2018
Merged

refactor(core) rephrase error messages #839

merged 1 commit into from
Jul 4, 2018

Conversation

j-maas
Copy link
Contributor

@j-maas j-maas commented Jul 3, 2018

Fixes typo, clarifies what actions are expected.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other: Error messages refactor

What is the current behavior?

There was a typo in an error message ("proccessed" instead of "processed").

Some messages did not clearly state what do check for ("verify whether" instead of "make sure that").

Parentheses were inlined in the sentence (like this). (Instead of this.)

What is the new behavior?

Typo is fixed and I tried to make some other messages more "actionable" by not only indicating what part to check, but also what to check for ("verify whether available" -> "make sure it is available"). (I hope I didn't actually make them worse. 😁 I am open to criticism.)

I extracted parentheses from the sentence, since they are self-contained.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Fixes typo, clarifies what actions are expected.
@coveralls
Copy link

coveralls commented Jul 3, 2018

Coverage Status

Coverage remained the same at 94.973% when pulling 3e55de5 on Y0hy0h:patch-1 into ced6729 on nestjs:master.

@kamilmysliwiec
Copy link
Member

Thanks @y0hy0h, I prefer your error messages either 🙂

@kamilmysliwiec kamilmysliwiec merged commit c1c5b15 into nestjs:master Jul 4, 2018
@j-maas j-maas deleted the patch-1 branch May 6, 2019 15:20
@lock
Copy link

lock bot commented Sep 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants