Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency ws [security] #9064

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 30, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change
ws 7.4.5 -> 7.4.6
ws 5.2.2 -> 5.2.3

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in ws@7.4.6 (websockets/ws@00c425e) and backported to ws@6.2.2 (websockets/ws@78c676d) and ws@5.2.3 (websockets/ws@76d47c1).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 30, 2022
@coveralls
Copy link

coveralls commented Jan 30, 2022

Pull Request Test Coverage Report for Build 90cba5ad-5103-407a-9f12-f1dd7626142b

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.12%

Totals Coverage Status
Change from base Build 599e1195-3839-4694-98d5-b64b8498a6f6: 0.0%
Covered Lines: 5762
Relevant Lines: 6122

💛 - Coveralls

@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 13 times, most recently from 349b803 to 8f77374 Compare January 31, 2022 08:43
@renovate renovate bot changed the title chore(deps): update dependency ws [security] chore(deps): update dependency ws to 7.4.6 [security] Jan 31, 2022
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 14 times, most recently from a9a60eb to 05a16e9 Compare February 1, 2022 16:20
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 27 times, most recently from e0fd9c4 to d7c802d Compare March 24, 2022 08:24
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch from d7c802d to 73db056 Compare April 5, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants