Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schedule): fix cron expression enum for "EVERY_YEAR" #1584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkasunsampath
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Current implementation for EVERY_YEAR is "0 0 1 0 *" which is incorrect. It was fixed by adding "0 0 1 1 *".

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@samchon
Copy link

samchon commented May 23, 2024

@micalevisk @jmcdo29 I also experienced the same problem. Hope to be fixed.

@sheerlox
Copy link
Contributor

The PR is correct, we need to merge this, as the EVERY_YEAR expression is currently unable to run since upgrading to 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants