Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): when imports list has no indentation #1036

Merged
merged 3 commits into from
May 16, 2022
Merged

fix(utils): when imports list has no indentation #1036

merged 3 commits into from
May 16, 2022

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented May 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes nestjs/nest-cli#1639

What is the new behavior?

now we can have a module declaration like the following:

@Module({
  imports: [
FooModule, // <<
  ],
})
export class AppModule {}

and nest g module bar will turn that into:

import { BarModule } from './bar/bar.module';

@Module({
  imports: [
FooModule,
BarModule, // <<
  ],
})
export class AppModule {}
Other examples
// FROM this:

@Module({
  imports: [
FooModule
  ],
})
export class AppModule {}

// TO this:

@Module({
  imports: [
FooModule,
BarModule
  ],
})
export class AppModule {}
// FROM this:

@Module({
  imports: [
 FooModule, // <<
  ],
})
export class AppModule {}

// TO this:

@Module({
  imports: [
 FooModule,
 BarModule, // <<
  ],
})
export class AppModule {}
// FROM this:

@Module({
  imports: [FooModule, // <<
  ],
})
export class AppModule {}

// TO this:

@Module({
  imports: [FooModule, BarModule, // <<
  ],
})
export class AppModule {}

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 9914ef3 into nestjs:master May 16, 2022
@kamilmysliwiec
Copy link
Member

Great work @micalevisk!

@micalevisk micalevisk deleted the fix-manager-indentation-issue branch May 16, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not generate module with nest cli
3 participants