-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix formatting when add spacing at the beginning and/end #1672
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import { normalizeToKebabOrSnakeCase } from '../../src/utils'; | ||
|
||
describe('normalizeToKebabOrSnakeCase', () => { | ||
it('should convert camelCase to kebab-case', () => { | ||
const input = 'camelCaseString'; | ||
const output = normalizeToKebabOrSnakeCase(input); | ||
expect(output).toBe('camel-case-string'); | ||
}); | ||
|
||
it('should replace spaces with dashes', () => { | ||
const input = 'string with spaces'; | ||
const output = normalizeToKebabOrSnakeCase(input); | ||
expect(output).toBe('string-with-spaces'); | ||
}); | ||
|
||
it('should keep underscores', () => { | ||
const input = 'string_with_underscores'; | ||
const output = normalizeToKebabOrSnakeCase(input); | ||
expect(output).toBe('string_with_underscores'); | ||
}); | ||
|
||
it('should handle empty string', () => { | ||
const input = ''; | ||
const output = normalizeToKebabOrSnakeCase(input); | ||
expect(output).toBe(''); | ||
}); | ||
|
||
it('should handle strings with leading/trailing spaces', () => { | ||
const input = ' leading and trailing spaces '; | ||
const output = normalizeToKebabOrSnakeCase(input); | ||
expect(output).toBe('leading-and-trailing-spaces'); | ||
}); | ||
|
||
it('should handle nil value', () => { | ||
const input = null; | ||
const output = normalizeToKebabOrSnakeCase(input); | ||
expect(output).toBe(undefined); | ||
}); | ||
|
||
it('should handle undefined value', () => { | ||
const input = undefined; | ||
const output = normalizeToKebabOrSnakeCase(input); | ||
expect(output).toBe(undefined); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure that the
str
parameter can be nil? 🤔 if yes, please add yet another test to cover this scenarioThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I just checked into the source and I saw that all implements with default value ...but I just added more unit tests