Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(): use next-gen convenience image; update npm version without sudo #980

Merged

Conversation

wodCZ
Copy link
Contributor

@wodCZ wodCZ commented Jul 17, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

The build page at circleci displays the following notice:

You’re using a deprecated Docker convenience image. Upgrade to a next-gen Docker convenience image.

Following the article we can see that the current images are no longer supported and no updates will be published.

Dec 31, 2021 - Legacy Convenience Images are no longer supported. This will be the last publishing day of these images. Existing tags will still exist on Docker Hub but will remain unchanged. There will be no support for bug or security fixes for existing tags. No new tags will be published after this day.

Issue Number: N/A

What is the new behavior?

The recommended convenience images are used and the deprecation warning is no longer displayed.

The previous image was pinned on Node.js v16.*. The new images don't support major-only version pinning and require an explicit minor version, 16.15 as of now (see github repo).

I couldn't find a list of changes between circleci/node and cimg/node, the only reference I found says it's a direct replacement.

Does this PR introduce a breaking change?

  • Yes
  • No

@wodCZ
Copy link
Contributor Author

wodCZ commented Jul 17, 2022

Note: this repository didn't run the CircleCI pipeline. It probably isn't configured?

@kamilmysliwiec
Copy link
Member

Same here nestjs/axios#487 (comment)

@kamilmysliwiec kamilmysliwiec merged commit 06292b7 into nestjs:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants