url doesn't take into consideration the setGlobalPrefix

[iangregsondev]

[ ] Regression 
[x] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Adding the url to the terminus doesn't take into consideration . the setGlobalPrefix..

For example, i have some metrics endpoints and that can be accessed via

https://localhost:3009/api/metrics

this is because I have the following set

    app.setGlobalPrefix("api")

but terminus ignores this, and it is still available on /health and not /api/health

The reason I need this is that the root is being proxied, so I need to add any custom endpoints under /api

I have terminus configured like so

 const healthEndpoint: TerminusEndpoint = {
      healthIndicators: [],
      url: "/health"
    }

Expected behavior

For terminus to take into consideration the setGlobalPrefix

Environment

Nest version: 6.1
 
For Tooling issues:
- Node version:11
- Platform:  MAC

[BrunnerLivio]

Thank you for your issue.

Sorry for taking so long. I am looking into it. I have to submit a PR first on nestjs/nest before continuing here. See nestjs/nest#2410.

[iangregsondev]

No problem @BrunnerLivio , thanks for getting back to me.

[BrunnerLivio]

Release 6.4.0:

Added useGlobalPrefix option - it will not take the globalPrefix as default because of backwards compatibility.

You can specify the useGlobalPrefix option in the TerminusModuleOptions or for each individual TerminusEndpoint as seen here:

const app = await NestFactory.create(ApplicationModule);
app.setGlobalPrefix('/api');

...

TerminusModule.forRoot({
  // Change the default option of all endpoints to use the global prefix
  useGlobalPrefix: true,
  endpoints: [
    {
      // Will result /liveness
      url: '/liveness',
      useGlobalPrefix: false,
      healthIndicators: []
    },
    {
      // Will result as /api/readiness 
      url: '/readiness',
      healthIndicators: []
    }
  ]
})

[cjancsar]

@BrunnerLivio how do you use this with TerminusModuleAsyncOptions?