Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guard): Add support for throwing throttling exceptions #1443

Conversation

ImChrisChen
Copy link
Contributor

@ImChrisChen ImChrisChen commented Apr 6, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

relevant issues: #894

Issue Number: N/A

What is the new behavior?

throwThrottlingException will receive a throttlerLimitDetail args, Used to prompt users about current count or other information in a restricted message.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jmcdo29
Copy link
Member

jmcdo29 commented Apr 6, 2023

Interesting proposal. Most of this data should already be available in the headers, but I suppose providing it in the body could be useful as well if the dev so chooses. If tests pass, can you create a changeset via the changeset wizard (yarn changeset) to make a minor release as this shouldn't be breaking

@jmcdo29
Copy link
Member

jmcdo29 commented Jul 6, 2023

Added to #1565

@jmcdo29 jmcdo29 closed this Jul 6, 2023
@jmcdo29 jmcdo29 mentioned this pull request Jul 6, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants