Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use sha256 instead of md5 to support openssl 3.0 and on #2095

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

jmcdo29
Copy link
Member

@jmcdo29 jmcdo29 commented Aug 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

OpenSSL 3.0+ has an issue with md5

Issue Number: #2094

What is the new behavior?

Use sha256 instead of md5

Does this PR introduce a breaking change?

  • Yes
  • No

By some small technicality, this could be a breaking change in that the old keys will no longer be valid. That should be a rather small margin of users and for such a short period of time (presumably) that it shouldn't be an issue.

Other information

@jmcdo29
Copy link
Member Author

jmcdo29 commented Aug 22, 2024

@Xaala let me know what you think. Should be a pretty straightforward change

@Xaala
Copy link

Xaala commented Aug 22, 2024

Exactly what I had in mind @jmcdo29 thanks for the quick turnaround.

@jmcdo29 jmcdo29 merged commit 3d1a9a5 into master Aug 22, 2024
3 checks passed
@jmcdo29 jmcdo29 deleted the fix/openssl-3.0-support branch August 22, 2024 15:41
@Xaala
Copy link

Xaala commented Aug 27, 2024

Confirmed to have fixed issues with upgrading to OpenSSL 3.0 and beyond, thanks again for the quick turn around, appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants