Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Override #17

Closed
navan101 opened this issue Jan 2, 2019 · 5 comments
Closed

Method Override #17

navan101 opened this issue Jan 2, 2019 · 5 comments

Comments

@navan101
Copy link

navan101 commented Jan 2, 2019

When the Override method, the param, and query hidden

@OverRide()
getMany(@param() params: ObjectLiteral,@query() query: RestfulParamsDto) {
return ...
}
method_override

@michaelyali
Copy link
Member

michaelyali commented Jan 10, 2019

@Navan123 thanks for pointing on that. I'll add a helper decorator for adding swagger implicit params to the override function

@icewind
Copy link

icewind commented Feb 4, 2019

@zMotivat0r Just curious if you have ETA for this?
Currently we can specify query params using @ApiImplicitQuery as a workaround.

@kairauer
Copy link

kairauer commented Mar 15, 2019

@Navan123 I've also wanted to have the query params displayed in Swagger. As a workaround I've added several @ApiImplicitQuery decorators. Adding these decorators to each method adds a lot of boilerplate code. My idea was to wrap these in a new custom decorator, but I didn't have enough time to try this.
This is the result:
swagger-params
These are the decorators: https://gist.github.com/kairauer/e3ea747224f76160717bd5f82e1ac23d

@michaelyali
Copy link
Member

michaelyali commented Mar 16, 2019

@Navan123 @icewind I'm working on a version 3.0.0 and will fix that.
@kairauer that's a pretty awesome idea and I'll add this too. Cheers!

@michaelyali michaelyali mentioned this issue Mar 21, 2019
@michaelyali
Copy link
Member

Shipped with v3.0.0

Darkein pushed a commit to Darkein/crud that referenced this issue Jun 22, 2022
Revert "fix: use `offset` instead of `skip`"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants