Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequelize crud service #274

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

hishamshikha
Copy link

Implementing sequelize curd service

@michaelyali
Copy link
Member

that's amazing, @hishamshikha! Thanks a lot for your efforts and your time!
I'll need some time to review this

@michaelyali
Copy link
Member

Btw, I've merged this one #265
And it'll be great if you could implement the same new search param handling for sequelize

@Bnaya
Copy link

Bnaya commented Oct 13, 2019

The PR includes packages/crud-sequelize/tsconfig.tsbuildinfo, i think this one needs to be gitignored?

@Bnaya
Copy link

Bnaya commented Dec 20, 2019

if this feature is mostly ready, would be awesome to have it published as separate package until merge, as canary or so,
For users to provide feedback, etc

Thanks!

@andremoniz
Copy link

+1 need this :)

@psi-4ward
Copy link

Nice! Want this too!

@andresmeidla
Copy link

Updated the branch and refactored crud-sequelize package by porting as much as possible from crud-typeorm.
Using the same tests (with a couple of exceptions, see @todo tags) for verification.

@andresmeidla
Copy link

@zMotivat0r should this branch be merged into v5 instead of master?

@cschuff
Copy link

cschuff commented Sep 11, 2020

@zMotivat0r Any updates on this PR? We could reaaaally make use of this 👍

@hakimio hakimio mentioned this pull request May 26, 2021
@rewiko
Copy link
Collaborator

rewiko commented Nov 28, 2021

I am trying to help and have forked this repo (can't reach the owner of this repo and do not have the credential for the npm repo).

See #710 (comment)

We can hopefully merge it via rewiko#5

@schealex schealex mentioned this pull request Feb 22, 2022
19 tasks
@Yedidyar
Copy link

Any update about intgrating sequelize?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants