CrudAuth filter as a mandatory filter in query #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue explained in #323 and #302. For use case of explained issue it works fine. Only concern is that this line: const defaultSearch = this.getDefaultSearchCondition(options, parsed); not only gets parsed.authFilter, but also options.query.filter and parsed.paramsFilter. Because of that I don't know if the fix can affect this two parameters in an unexpected behavior. Review necessary by a project author for other use cases.
|
Please @zMotivat0r, review this as author of CrudAuth. Thanks! |
|
Thanks a lot for your effort @kereslas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue explained in #323 and #302.
For use case of explained issue it works fine. Only concern is that this line:
const defaultSearch = this.getDefaultSearchCondition(options, parsed);
not only gets parsed.authFilter, but also options.query.filter and parsed.paramsFilter. Because of that I don't know if the fix can affect this two parameters in an unexpected behavior. Review necessary by a project author for other use cases.