Feature/nested query #42

Diluka · 2019-03-22T03:18:38Z

nested field can be filtered by query
page-info can be custom
bug fix

1. support query on nested fields 2. add more swaggers

fix(core): dynamic create class for inject must change name fix(swagger): add per_page alias fix(tslint): suppress warnings and errors

1. page only when page param exists or return list like before 2. page-info response can be custom 3. `take` and `skip` distinguish `0` or `null` to decide if it is paging or listing 4. override `decidePagination` method can make it always paging or listing

michaelyali · 2019-03-22T06:14:06Z

Awesome! I'll review and merge by the EOD. Thanks!
Btw, are you in NestJs Discord channel? (https://discord.gg/jBcGvR)

src/interceptors/restful-params.interceptor.ts

michaelyali · 2019-03-22T11:12:49Z

src/decorators/helpers.ts

@@ -223,6 +252,7 @@ export function setValidationPipe(crudOptions: CrudOptions, group: CrudValidate)
    : undefined;
 }

+// FIXME Due to issue https://github.com/nestjs/nest/issues/1604, someone can't use global parser pipe without modify ParseIntPipe
 export function setParseIntPipe() {


this function is deprecated.

Diluka added 4 commits March 21, 2019 11:46

squash preview changes

b63d4bb

1. support query on nested fields 2. add more swaggers

bug fix

ac4eeb1

fix(core): dynamic create class for inject must change name fix(swagger): add per_page alias fix(tslint): suppress warnings and errors

fix(deps): update deps

4d7e43f

Diluka requested a review from michaelyali March 22, 2019 03:43

Diluka commented Mar 22, 2019

View reviewed changes

src/interceptors/restful-params.interceptor.ts Show resolved Hide resolved

Merge branch '3.0.0' into feature/nested-query

1e33fc8

michaelyali approved these changes Mar 22, 2019

View reviewed changes

michaelyali merged commit 033ad74 into nestjsx:3.0.0 Mar 22, 2019

michaelyali mentioned this pull request Mar 22, 2019

WIP: v3.0.0 #39

Merged

Diluka deleted the feature/nested-query branch March 27, 2019 08:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/nested query #42

Feature/nested query #42

Diluka commented Mar 22, 2019

michaelyali commented Mar 22, 2019

michaelyali Mar 22, 2019

Feature/nested query #42

Feature/nested query #42

Conversation

Diluka commented Mar 22, 2019

michaelyali commented Mar 22, 2019

michaelyali Mar 22, 2019

Choose a reason for hiding this comment