v.3.2.0

[michaelyali]

Features:

• controller - added UsePathInterceptors decorator that allows to wire up RestfulQueryInterceptor and RestfulParamsInterceptor on custom CrudController routes (those interceptors are already wired up on @Override() routes) (How to reuse queries in 3.x? #45)
• repository service - added simple findOne and find methods (link to the repo methods)

[Diluka]

LGTM

[Diluka]

@zMotivat0r wait a minute. Does it support 5.x?

[michaelyali]

@zMotivat0r wait a minute. Does it support 5.x?

5.x of what? NestJs?

[Diluka]

Yes, I mean NestJS. And I find it only supporting 6 and above. I suggest to define the peerDependencies

[Diluka]

Seems OK

[Diluka]

crud/src/typeorm/repository-service.class.ts

Line 22 in 9cb3331

protected options: RestfulOptions = {};

Is there necessary to have 2 options separated.

It's uncontrollable in some scenarios. For example:
someone override controller#getManyBase, modify options and call service#getMany.
but options maybe changed in service#getMany and behavior unexpected.

crud/src/typeorm/repository-service.class.ts

Lines 60 to 65 in 9cb3331

	public async getMany(
	query: RequestParamsParsed = {},
	options: RestfulOptions = {},
	): Promise<GetManyDefaultResponse<T> | T[]> {
	const builder = await this.buildQuery(query, options);
	const mergedOptions = Object.assign({}, this.options, options);

[michaelyali]

@Diluka what's your suggestion?

[Diluka]

A few questions about this

1. Why there has options property on service?
2. Can options merged in interceptor?

My suggestion is
service#getMany and other methods just do CRUD work. Do not modify options in those methods.

[michaelyali]

1. Initially, it was designed to place some common options in a service rather than duplicating in several controllers if you have few controllers for one service (e.g. maxLimit, cache).
2. Haven't tried that yet. Need to think about it.

Anyways, it will be another breaking change with major version bump.
My suggestion is to release this and to find a way how to have common options in one place (e.g. maxLimit, cache) without merging options in a service.

[Diluka]

@zMotivat0r OK

[michaelyali]

I just forgot to add changes to README :(