Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remodel to dev #444

Closed
wants to merge 40 commits into from
Closed

Remodel to dev #444

wants to merge 40 commits into from

Conversation

FrankBakkerNl
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

FrankBakkerNl and others added 13 commits August 4, 2021 17:30
* Inject into app classes

* Added tests

* Reactored INetDaemonApp interfaces

* Clean commeted code

* Remove NetDaemonAppBase.Equals which is not needed anymore

* renamed GetTypesWhereSubclassOf

* Fix review

* Extracted and tested app sorting
* Working app context

* All Works

* Fix review comments

* Clean up and fix warnings
* move app instantiation from YamlAppConfig.cs to a new class

* make AppInstantiator.cs internal
* add support for apps without yaml

* adjust code style
# Conflicts:
#	src/App/NetDaemon.App/Common/INetDaemonAppBase.cs
#	src/App/NetDaemon.App/Common/NetDaemonAppBase.cs
* DI improvements
State cache as singleton,
IHaContext as Scoped
TTS injectable into apps

* fix compile error in tests
* AdjusetdEntityModel

* Added IsOn and IsOff to EntityState
* Enabled DI into properties from YAML

* Remove file that should not  be here

* remove redundant appid paramater

* Fix comments
* Entity.CallService

* remove focus
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #444 (77ffdda) into dev (4275efc) will decrease coverage by 40.24%.
The diff coverage is 41.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #444       +/-   ##
===========================================
- Coverage   54.46%   14.21%   -40.25%     
===========================================
  Files          83      126       +43     
  Lines        4616     4826      +210     
  Branches      714      734       +20     
===========================================
- Hits         2514      686     -1828     
- Misses       1873     4087     +2214     
+ Partials      229       53      -176     
Flag Coverage Δ
unittests 14.21% <41.82%> (-40.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/ApplicationContexts/AppBaseApplicationContext.cs 0.00% <0.00%> (ø)
...p/Common/ApplicationContexts/ApplicationContext.cs 0.00% <0.00%> (ø)
...App/Common/ApplicationContexts/ApplicationScope.cs 0.00% <0.00%> (ø)
...n/ApplicationContexts/NonBaseApplicationContext.cs 0.00% <0.00%> (ø)
...Daemon.App/Common/ApplicationPersistenceService.cs 0.00% <0.00%> (ø)
...c/App/NetDaemon.App/Common/IApplicationMetadata.cs 0.00% <0.00%> (ø)
.../App/NetDaemon.App/Common/NetDaemonAppAttribute.cs 0.00% <0.00%> (ø)
src/App/NetDaemon.App/Common/NetDaemonAppBase.cs 0.00% <0.00%> (-71.66%) ⬇️
src/App/NetDaemon.App/Common/RuntimeInfoManager.cs 0.00% <0.00%> (ø)
src/App/NetDaemon.App/DependencyInjectionSetup.cs 0.00% <0.00%> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4275efc...77ffdda. Read the comment docs.

@helto4real helto4real had a problem deploying to CI - release environment August 29, 2021 21:41 Failure
@ludeeus ludeeus had a problem deploying to CI - release environment September 10, 2021 09:22 Failure
* UnitTest model 3

# Conflicts:
#	src/Model3/NetDeamon.Model3/Internal/AppScopedHaContextProvider.cs

* Fix nullable warning

* Added coverlet refrences
Code cover support for model3
* Made new style apps start stop and restore

* Bump Microsoft.AspNetCore.Mvc.NewtonsoftJson from 5.0.9 to 5.0.10 (#468)

Bumps [Microsoft.AspNetCore.Mvc.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.9 to 5.0.10.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](dotnet/aspnetcore@v5.0.9...v5.0.10)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Mvc.NewtonsoftJson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump Microsoft.AspNetCore.TestHost from 5.0.9 to 5.0.10 (#469)

Bumps [Microsoft.AspNetCore.TestHost](https://github.com/dotnet/aspnetcore) from 5.0.9 to 5.0.10.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](dotnet/aspnetcore@v5.0.9...v5.0.10)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.TestHost
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Another cleanup

* All tests working again + clead nicely

* Fixed warnings

* removed unused reference

* Check isDisposed

* Extracted AppManagement from NetDaemonHost

* fixed review comments

* Update admin version (#472)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
@FrankBakkerNl FrankBakkerNl temporarily deployed to CI - release environment October 4, 2021 05:42 Inactive
* modify code generator contracts

* Bump JoySoftware.HassClient from 21.30.1-beta to 21.30.1-beta

* pass entities to CodeGenerationHandler

* add camel case string extension

* add targeted service call

* add new codegen

* fix warnings

* move new code generator to daemon.runner

* move code generator related stuff

* fix extension methods and helper methods

* Fix wrong DI setup order (#461)

* extract field mapping

* fixes from pr comments

* fixes from pr comments

* Moved codegen to new project

* Added Tests for CodeGen

* fix incorrect domain in extensionMethod

* Move code gen to correct namespace

* Fix merged test

* Added xml coments to ServiceTarget

* fix test

Co-authored-by: Zorgino <maxsu4@gmail.com>
* Added Entity() and AllEntities() to IHaContext

* add missing files

* Change type if AllEntities

* Fix

* Fix
* Added Events to IHaContext

* Remove unused variable

* Fix comment
* Implemented code generation CLI

* Fixes

* disable warning

* Update NetDaemon.Model3.CodeGenerator.csproj

Removed empty folder
@FrankBakkerNl
Copy link
Contributor Author

Superseded by #485

@helto4real helto4real deleted the remodel branch November 3, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants