Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Access Leaf and Spine Interface Selector port shutdown support for APIC 4.x/5.x #96

Closed
wants to merge 7 commits into from

Conversation

devegupt
Copy link
Contributor

@devegupt devegupt commented Jun 7, 2024

This PR includes the enhancement to support the port shutdown operation on APIC 4.x/5.x while using "new_interface_configuration: false"

@devegupt devegupt changed the title Access Leaf and Spine Interface Selector shutdown support Access Leaf and Spine Interface Selector shutdown support for APIC 4.x/5.x Jun 7, 2024
@devegupt devegupt changed the title Access Leaf and Spine Interface Selector shutdown support for APIC 4.x/5.x Auto Access Leaf and Spine Interface Selector port shutdown support for APIC 4.x/5.x Jun 7, 2024
@andbyrne
Copy link
Contributor

This feature shouldn't use the existing modules. A dedicated blacklist module should be created and called with the appropriate parameters if a relevant auto mode is enabled. You can re-use the majority of the code, but just pull it out into a separate module.

@devegupt
Copy link
Contributor Author

This feature shouldn't use the existing modules. A dedicated blacklist module should be created and called with the appropriate parameters if a relevant auto mode is enabled. You can re-use the majority of the code, but just pull it out into a separate module.

@andbyrne Thanks for the inputs. Sure, will port the code to a new TF module.

@andbyrne andbyrne self-requested a review June 20, 2024 00:18
@devegupt devegupt marked this pull request as draft June 24, 2024 20:26
devegupt and others added 4 commits July 14, 2024 20:58
* add allow origins (netascode#106)

* Defaults updates

* Netflow policies (netascode#112)

* add netflow policies

* typo

* cosmetic doc fixes

* docs

* typo

* update modules

* Defaults updates

---------

Co-authored-by: Justyna Chowaniec <79261946+juchowan@users.noreply.github.com>
Co-authored-by: netascode-gen <netascode-gen@cisco.com>
* add allow origins (netascode#106)

* Defaults updates

* Netflow policies (netascode#112)

* add netflow policies

* typo

* cosmetic doc fixes

* docs

* typo

* update modules

* Defaults updates

---------

Co-authored-by: Justyna Chowaniec <79261946+juchowan@users.noreply.github.com>
Co-authored-by: netascode-gen <netascode-gen@cisco.com>
* add allow origins (netascode#106)

* Defaults updates

* Netflow policies (netascode#112)

* add netflow policies

* typo

* cosmetic doc fixes

* docs

* typo

* update modules

* Defaults updates

---------

Co-authored-by: Justyna Chowaniec <79261946+juchowan@users.noreply.github.com>
Co-authored-by: netascode-gen <netascode-gen@cisco.com>
@devegupt
Copy link
Contributor Author

I am closing this PR and will work on a new branch.

@devegupt devegupt closed this Jul 29, 2024
@devegupt devegupt deleted the interface-config branch October 22, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants