Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Create container registry repo API #43

Merged
merged 2 commits into from
May 31, 2022
Merged

add Create container registry repo API #43

merged 2 commits into from
May 31, 2022

Conversation

NishanthSpShetty
Copy link
Contributor

Description

Create repository in ECR.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

why

needed when using private repo in ECR to push images.

How Has This Been Tested?

manual test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sid255
sid255 reviewed May 31, 2022
View reviewed changes
pkg/service/aws/ecr.go Outdated Show resolved Hide resolved
sid255
sid255 reviewed May 31, 2022
View reviewed changes
pkg/service/aws/ecr.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
3.8% 3.8% Duplication

sid255
sid255 approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@sid255 sid255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NishanthSpShetty NishanthSpShetty merged commit e55acfb into main May 31, 2022
@NishanthSpShetty NishanthSpShetty deleted the create-ecr-repo branch May 31, 2022 09:48
@NishanthSpShetty NishanthSpShetty restored the create-ecr-repo branch May 31, 2022 09:48
@NishanthSpShetty NishanthSpShetty deleted the create-ecr-repo branch May 31, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sid255 sid255 sid255 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NishanthSpShetty @sid255