Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed version conflicts for social-auth-core #982

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Fixed version conflicts for social-auth-core #982

merged 2 commits into from
Apr 6, 2023

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Apr 6, 2023

Related Issue: -

New Behavior

  • Use the social-auth-core version defined by the Netbox project

Contrast to Current Behavior

  • Builds fail if we used our own (different) version

Discussion: Benefits and Drawbacks

  • See above

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Fixed version conflicts with social-auth-core

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

cimnine
cimnine approved these changes Apr 6, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@tobiasge @cimnine
Fixed wording
5a29364 
Co-authored-by: Christian Mäder <cimnine@users.noreply.github.com>
@tobiasge tobiasge merged commit 7c2e012 into netbox-community:develop Apr 6, 2023
@tobiasge tobiasge deleted the fix-social-auth-core branch April 6, 2023 10:37
@tobiasge tobiasge mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasge @cimnine @ryanmerolle