Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New paragraph line breaks do not render in journal entry table comments #12363

Closed
mattspera opened this issue Apr 27, 2023 · 1 comment · Fixed by #12435
Closed

New paragraph line breaks do not render in journal entry table comments #12363

mattspera opened this issue Apr 27, 2023 · 1 comment · Fixed by #12435
Assignees
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@mattspera
Copy link

mattspera commented Apr 27, 2023

NetBox version

v3.3.7

Python version

3.8

Steps to Reproduce

  1. Click on Devices in the side menu and then select Devices from the Devices submenu
  2. Click on a Device object and select the Journal tab
  3. Create a new journal entry and enter the following in the comments section:

image

Expected Behavior

The journal entry comments attribute within the device object's journal entry table should render a line break between the two paragraphs.

This behaviour is correctly demonstrated when clicking into the Journal Entry object and observing the Comments attribute:
image

Observed Behavior

The journal entry comments attribute within the device object's journal entry table does not render a line break between the two paragraphs:
image

Prior to the user interface updates in v3, the journal entry comments attribute within the device object's journal entry table would correctly render new paragraph line breaks.

@mattspera mattspera added the type: bug A confirmed report of unexpected behavior in the application label Apr 27, 2023
@mattspera mattspera changed the title New paragraph line breaks do not render in journal entry comments New paragraph line breaks do not render in journal entry table comments Apr 27, 2023
@jeremystretch
Copy link
Member

The underlying rendering is functioning correctly, however we have CSS in place that removes the bottom margin from <p> elements within a table.

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 27, 2023
@arthanson arthanson self-assigned this May 2, 2023
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label May 2, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label May 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants