12363 update paragraph spacing on journal table

[arthanson]

Fixes: #12363

Updates paragraph spacing on journal table so comments are shown correctly spaced. Only effects journal-table as other tables should display with condensed paragraphs.

[arthanson]

changed to a generic spaced-paragraph-table utility class. let me know if you want any further changes.

[jeremystretch]

Rather than adding a one-off class for this, let's do some digging to determine why and how the margin is being removed in the first place. We can attribute the style to this rule in netbox.scss:

netbox/netbox/project-static/styles/netbox.scss

Lines 232 to 235 in 78ec3a6

	p {
	// Remove spacing from paragraph elements within tables.
	margin-bottom: 0;
	}

Running git blame on this file show that the change was part of a large array of changes two years ago, likely when the v3.0 UI was still being refined. So I think it's reasonable to just remove it entirely. If complaints arise that this results in suboptimal rendering elsewhere in the UI, we can then add a "condensed" class to remove the margin where needed.

[jeremystretch]

I actually remember now why we added this. Rendered Markdown text, even a single line, always creates a <p> element. This adds unnecessary white space to the bottom of the table cell (which really triggers some people).

I wonder if we can easily apply the rule only to the last <p> element in the cell. This would retain white space between paragraphs without any extraneous space at the end.

[kkthxbye-code]

wonder if we can easily apply the rule only to the last <p> element in the cell.

I'm not really a CSS aficionado, but the :last-child pseudo-class would probably work.

[arthanson]

That historical context helps. Reverted and made the last-child to 0 and the regular p table spacing to .5em - this allows you to still see paragraph spacing, but gets rid of it at the bottom and reduces the spacing to conserve line height:

[jeremystretch]

Thanks @arthanson!