feat: support additional v4.3 types and fields #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ltucker
force-pushed
the
support_v43_updates
branch
from
79907c7 to
967a9f0
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
jajeffries
reviewed
Jul 23, 2025
netbox_diode_plugin/tests/v4.2.3/tests/test_api_apply_change_set.py
Outdated
Show resolved
Hide resolved
jajeffries
reviewed
Jul 23, 2025
netbox_diode_plugin/tests/v4.2.3/tests/test_api_apply_change_set.py
Outdated
Show resolved
Hide resolved
leoparente
approved these changes
Jul 23, 2025
jajeffries
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: use of new types and fields also requires updated SDKs and diode backend, but
this remains compatible with existing versions.
etc
This pull request introduces support for testing the plugin against multiple NetBox versions, including the addition of version-specific configurations and updates to dependencies. It also upgrades the default NetBox version to
v4.3.3-3.3.0and adjusts the Makefile and Docker configurations to accommodate these changes.Support for Multiple NetBox Versions:
matrix.netboxstrategy in.github/workflows/lint-tests.ymlto test against multiple NetBox versions (""and"v4.2.3"). ([.github/workflows/lint-tests.ymlR29](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-7ff5b316f9a4896dcea6d970dc3df6d670c4b14744a5d6e3ae19358ce6835dfcR29))Makefileto dynamically adjust paths and test selectors based on theNETBOX_VERSIONenvironment variable. ([MakefileR7-R45](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R7-R45))docker/v4.2.3/, includingDockerfile-diode-netbox-plugin,docker-compose.yaml, anddocker-compose.test.yaml. These configurations ensure compatibility with NetBoxv4.2.3. ([[1]](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-bc3e6e5a551c159d4974cdeca53254ccc557f38765f953e49374df6f315d881cR1-R12),[[2]](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-557425242a4ba38afdb72eba8fcf8b3a501fc3a8aca3e61e7fd731bd6fca4122R1-R5),[[3]](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-2efe46e43c32c87fa317522d238ab02c6ba209f284cc381995cb5779acaa9d5fR1-R92))Dependency and Version Updates:
docker/Dockerfile-diode-netbox-pluginanddocker/docker-compose.yamltov4.3.3-3.3.0. ([[1]](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-112ee4e06e4a556534c26208d1566b12ae5a6fcf415f8e9d465c6f5d78ebc4ebL1-R1),[[2]](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-89fafc265c1fa601cf2364b20be83308031335fda9467fcf3249d5ec1c0c8172L4-R4))netboxlabs-netbox-branchingdependency indocker/requirements-diode-netbox-plugin.txtfrom0.5.7to0.6.0. ([docker/requirements-diode-netbox-plugin.txtL7-R7](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-3b478cf01739a25e40b5657b8e5034cbeaa862a413b355e1f0357cad61a471a7L7-R7))Build and Test Improvements:
.github/workflows/lint-tests.ymlto pass theNETBOX_VERSIONdynamically to the Makefile. ([.github/workflows/lint-tests.ymlL50-R51](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-7ff5b316f9a4896dcea6d970dc3df6d670c4b14744a5d6e3ae19358ce6835dfcL50-R51))uvtool for dependency installation and set theVIRTUAL_ENVenvironment variable for better compatibility. ([docker/Dockerfile-diode-netbox-pluginL12-R13](https://github.com/netboxlabs/diode-netbox-plugin/pull/122/files#diff-112ee4e06e4a556534c26208d1566b12ae5a6fcf415f8e9d465c6f5d78ebc4ebL12-R13))