Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeDiff records are created automatically for excluded objects #57

Closed
jeremystretch opened this issue Aug 20, 2024 · 0 comments · Fixed by #58
Closed

ChangeDiff records are created automatically for excluded objects #57

jeremystretch opened this issue Aug 20, 2024 · 0 comments · Fixed by #58
Assignees
Labels
type: bug Something isn't working

Comments

@jeremystretch
Copy link
Contributor

Plugin Version

v0.3.1

NetBox Version

v4.1-beta1

Python Version

3.10

Steps to Reproduce

The signal receiver which watches for object events and creates ChangeDiffs in response does not currently filter out object types that should be excluded.

Expected Behavior

ChangeDiffs should be created/updated only for supported models, e.g. those returned by get_branchable_object_types().

Observed Behavior

A ChangeDiff is created/updated even for models which don't support branching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant