Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): Add retainOnceInViewport prop to Viewport.WithPlaceholder #111

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

bevkoski
Copy link
Collaborator

This feature is inspired by a Medium comment.

It adds support for keeping a component wrapped by Viewport.WithPlaceholder displayed once it enters the viewport.

With retainOnceInViewport set to false (default behavior), the component will be replaced by a placeholder once it leaves the viewport.
With retainOnceInViewport set to true, the component will be kept displayed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 335

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 77.211%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/components/src/viewport/withPlaceholder/index.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
packages/components/src/viewport/withPlaceholder/index.js 1 0.0%
Totals Coverage Status
Change from base Build 334: -0.6%
Covered Lines: 852
Relevant Lines: 1030

💛 - Coveralls

@bevkoski bevkoski merged commit c88a826 into master Jul 16, 2018
@bevkoski bevkoski deleted the feat/retain-once-in-viewport branch July 16, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants