Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Vendor archives #1434

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Vendor archives #1434

merged 2 commits into from
Dec 8, 2023

Conversation

arkamar
Copy link
Contributor

@arkamar arkamar commented Dec 6, 2023

Would it be possible to release vendor archives for new versions? This is how it can be done. I tried to integrate it to a current workflow.

@ilyam8
Copy link
Member

ilyam8 commented Dec 6, 2023

Hey, @arkamar. Thanks for the contribution! Can you clarify why this is needed?

@arkamar
Copy link
Contributor Author

arkamar commented Dec 6, 2023

I'm working on making a Gentoo package for the netdata go.d.plugin. The patch I've sent helps me as a packager to meet Gentoo's packaging rules, which require separate downloads for dependencies (the package is built in a sandbox without internet connection). Previously, we listed dependencies based on the go.sum file, but this method is now deprecated in Gentoo. We use vendor files instead (see Writing Go Ebuilds - Packaging the dependencies). Without a vendor archive from upstream, I'd have to manually create one for each release. Having an upstream vendor archive makes maintaining the package easier for me, and could help any other user or distribution that needs pre-vendored dependencies.

@ilyam8
Copy link
Member

ilyam8 commented Dec 8, 2023

Thanks, @arkamar. lgtm!

@ilyam8 ilyam8 merged commit 0a2ab74 into netdata:master Dec 8, 2023
10 checks passed
@arkamar
Copy link
Contributor Author

arkamar commented Dec 9, 2023

Thank you for merging it!

@arkamar arkamar deleted the vendor-archive branch December 9, 2023 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants