Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo config for Amazon Linux 2023. #17330

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Add repo config for Amazon Linux 2023. #17330

merged 4 commits into from
Apr 11, 2024

Conversation

PaulSzymanski
Copy link
Contributor

Summary

dnf and yum resolve $releasever to a verbose release version (e.g. 2023.4.20240401). However, there is no need to create repositories for every version Amazon comes up with.

Fixes #17324

Test Plan

None

dnf and yum resolve $releasever to a verbose release version (e.g. 2023.4.20240401).
However, there is no need to create repositories for every version Amazon comes up with.

Resolves #17324
@PaulSzymanski PaulSzymanski requested a review from a team as a code owner April 5, 2024 23:26
@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Apr 5, 2024
Copy link
Member

@Ferroin Ferroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the single review comment.

packaging/repoconfig/netdata-repo.spec Show resolved Hide resolved
Copy link
Member

@Ferroin Ferroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed this when reviewing earlier, but this change also needs the release number in the spec file to be bumped and an associated entry in the %changelog section at the end of the spec file.

@Ferroin Ferroin merged commit d1a5035 into netdata:master Apr 11, 2024
167 checks passed
@Ferroin
Copy link
Member

Ferroin commented Apr 11, 2024

@PaulSzymanski Thanks for the fix, and sorry it took so long to get merged!

@PaulSzymanski PaulSzymanski deleted the al2023 branch April 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Install script on Amazon Linux 2023 fails to install native
3 participants