Add Hirschmann HiOS driver #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with HiOS 8 on the BRS40 platform.
SCadilhac
requested changes
Aug 28, 2022
There was a problem hiding this comment.
Thanks for the contribution!
Before merging, I would need the following changes to the code:
- Please reformat the code (tab-based indentation, correct spacing) - cf. VSCode formatting feature
- You should declare "enable" as a macro of "ssh", and call it directly rather than explicitly going through "authenticated" mode
- Please set author to shorter form e.g. "B. Kresina"
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to share my work for the industrial switch HiOS platform by Hirschmann. I hope some people out there can utilize it. The driver was tested with HiOS 8 and the BRS40 platform of devices.