New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiohttp: app.make_handler is deprecated; switch to application runners #197

Closed

LeonardSchuler opened this issue Jul 3, 2021 · 0 comments · Fixed by #298

Labels

good first issue

LeonardSchuler commented Jul 3, 2021 •

edited

Loading

While reading the code I found the following (minor) issue.

The aiohttp docs states: app.make_handler() is deprecated and will be removed in future aiohttp versions. Please use Application runners instead.

The metaflow-service uses app.make_handler() in metadata_service/server.py and in migration_service/migration_server.py

saikonen added the good first issue label

saikonen mentioned this issue

chore: fix deprecated way of initialising aiohttp app in services #298

Merged

saikonen closed this as completed in #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment