Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error when <a> tag does not have a href #9

Merged
merged 1 commit into from
Sep 29, 2015

Conversation

dtinth
Copy link
Contributor

@dtinth dtinth commented Aug 21, 2015

When the <a> tag does not have a href, url is false. Calling url.replace() results in “undefined is not a function” error.

@dtinth
Copy link
Contributor Author

dtinth commented Sep 29, 2015

Hello……………………?

netgusto pushed a commit that referenced this pull request Sep 29, 2015
Fix an error when <a> tag does not have a href
@netgusto netgusto merged commit 5ba4d0f into netgusto:master Sep 29, 2015
@netgusto
Copy link
Owner

Hey thanks :) Nice PR, clean with tests and all. Sorry for the delay though !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants