This repository has been archived by the owner on Jun 27, 2020. It is now read-only.
Updated django-rest-framework version requirement #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
reviewed
Apr 19, 2017
requirements.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| django>=1.9,<1.11 | |||
| djangorestframework>=3.3,<3.6 | |||
| djangorestframework>=3.3,<=3.6.2 | |||
There was a problem hiding this comment.
@rohithasrk follow the convention, that is, to put less than the next major version, that is, <3.7, this way we won't have to change this number at each minor release of django-rest-framework 3.6 (eg when 3.6.3 comes out). We assume new minor versions do not bring backward incompatible changes.
There was a problem hiding this comment.
Oh. I see @nemesisdesign. Updated 👍
rohithasrk
force-pushed
the
upgrade-rest
branch
from
2871e3b
to
35760c9
Compare
|
@rohithasrk thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
3.6.2 seems to be the latest version and all the tests seem to run perfectly.