fix VMC.info() error

[mmezic]

Solves #983 by renaming self.sr to self.preconditioner.

Also fixes an error in the function info(obj, depth=None) when obj has an attribute info which is not a method.

[PhilipVinc]

Thanks.

Though I think we should change repr to give more information and get rid of this info...

But that's a good stopgap

[PhilipVinc]

I did not know that hasattr syntax! Nice

[femtobit]

Indeed, VMC.info() is a bit of a leftover from v2. But this fix is nice to have for now, thanks @mmezic!

[PhilipVinc]

Out of curiosity, @mmezic , do you actually use info() ? For what?

[codecov-commenter]

Codecov Report

Merging #984 (851f83d) into master (a9da8f2) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #984   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files         172      172           
  Lines       10448    10448           
  Branches     1490     1490           
=======================================
  Hits         8374     8374           
  Misses       1677     1677           
  Partials      397      397           

Impacted Files	Coverage Δ
netket/driver/vmc.py	89.79% <ø> (ø)
netket/driver/vmc_common.py	25.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9da8f2...851f83d. Read the comment docs.

[femtobit]

I did not know that hasattr syntax! Nice

Actually, that doesn't work as far as I can tell:

>>> class VMC: 
...     def info(self):
...         print("info")                                                                                                                  
...
>>> vmc = VMC()                                                                                                           
>>> vmc.info()                                                                                                            
info
>>> hasattr(vmc, "info")                                                                                                  
True
>>> hasattr(vmc, "info()")                                                                                               
False

This should work better:

>>> hasattr(vmc, "info") and callable(vmc.info)
True

[mmezic]

Out of curiosity, @mmezic , do you actually use info() ? For what?

I came across info() while reading the documentation and testing a few things. I don't need this function, so you can probably remove it. I was just surprised that it causes the error by default.

[femtobit]

[...] because preconditioner has an attribute "info", which is not callable. Your change fixes it.

Well, our test coverage of this method is obviously lacking. The fact that info is an attribute on the preconditioner is probably also unintended. Good that you spotted those.

I still think we should still fix the method on VMC in this PR, but maybe deprecate it in the future. @PhilipVinc ?

[PhilipVinc]

What fix do we need?

I'm in Favour of deprecating.
Actually I've long wanted to transition to Jupiter's pretty print methods for this interactive stuff