Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): use svglint #1709

Merged
merged 1 commit into from
Sep 22, 2022
Merged

chore(project): use svglint #1709

merged 1 commit into from
Sep 22, 2022

Conversation

LitoMore
Copy link
Member

Closes #1192

Rules

  • Avoid non-SVG data images - those data images usually take up a lot of file size

There are still some images that do not to the rule in our project. We could fix them in future pull requests.

To find out all non-SVG data images, use:

pnpm svglint **/*.svg

Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LitoMore LitoMore merged commit 576c90c into netless-io:main Sep 22, 2022
@LitoMore LitoMore deleted the add-svglint branch September 22, 2022 04:55
@LitoMore
Copy link
Member Author

@BlackHole1 I notice all those non-SVG images are used in the <AppStoreButton/>. Is this button still in use? I can't find any usage of the button in our code base.

@BlackHole1
Copy link
Collaborator

@BlackHole1 I notice all those non-SVG images are used in the <AppStoreButton/>. Is this button still in use? I can't find any usage of the button in our code base.

/cc @crimx @hyrious @Cheerego7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore]: add optimization svg git hook
2 participants